feat(wasm): use only one Engine per global context
#5447
Merged
+8
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instantiating a `wasmtime::Engine` is an expensive operation, so it is best to do it only once for the duration of a `GlobalContext`. Cloning an engine is, however, not an expensive operation (just an `Arc::clone`) and we use it to avoid referring to the global context already referred to by the instantiated `ClarityWasmContext`. See-also: stacks-network/clarity-wasm#468
krl
approved these changes
Nov 12, 2024
csgui
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Code LGTM. Just a remark.
Since this PR changes how the context is initialized and likely impacts the roundtrip on contract calls, it would be useful to benchmark and profile the code both before and after this PR.
@obycode What do you think about making an effort to compare the changes and their impact on contract calls introduced by this PR?
|
I think this is a definite improvement, but does not yet close stacks-network/clarity-wasm#468. For that issue, I'd like to go further and link in the callee contract into the current Wasm instance to call the function directly, rather than leaving Wasm and passing through Rust to go back to Wasm. |
|
I added a diagram in the issue to help clarify. |
Acaccia
approved these changes
Nov 12, 2024
obycode
merged commit 05467a2
into
stacks-network:feat/clarity-wasm-develop
22 of 24 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instantiating a
wasmtime::Engineis an expensive operation, so it is best to do it only once for the duration of aGlobalContext. Cloning an engine is, however, not an expensive operation (just anArc::clone) and we use it to avoid referring to the global context already referred to by the instantiatedClarityWasmContext.See-also: stacks-network/clarity-wasm#468