-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: rpc blockbyheight #5445
base: develop
Are you sure you want to change the base?
Conversation
…t height test value
…ests::nakamoto_integrations::v3_blockbyheight_api_endpoint to github workflows
Updated the pull request for including only the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just need to get CI to pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rdeioris I see you've updated rpc-endpoints.md
, but please also update docs/rpc/openapi.yaml
with this new endpoint. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, just flagged a couple of typos. I also second Hank's request to update the openapi.yml.
Description
Hi, this is my initial attempt at approaching the codebase by covering an issue out of the critical path. This patch
adds a new RPC call:
/v3/blocks/height/{block_height}
as specified in issue #4358Applicable issues
Additional info (benefits, drawbacks, caveats)
The endpoint is fork-safe as it allows to specify an additional query_string (?tip=x) that will force the search in the MARF for a specific tip block hash
Checklist
docs/rpc/openapi.yaml
andrpc-endpoints.md
for v2 endpoints,event-dispatcher.md
for new events)clarity-benchmarking
repobitcoin-tests.yml