Fix logs to use inplace formatting in stacks node

[jferrant]

This was more of a just try it out to see if its an improvement. There are many instances where I think it is. Should we introduce this as a general standard from now on?

[obycode]

If we're going to do this, maybe we should also use named parameters when the expression cannot be directly inserted in place. I find it a little less clear when there is a mix of empty {} and those with names in them. For example:

        test_debug!(
             "Miner {miner_id}: Block commit transaction builds on {parent_block_ptr},{parent_vtxindex} (parent snapshot is {parent_block_snapshot_opt:?})",
             miner_id = miner.id,
             parent_block_ptr = block_commit_op.parent_block_ptr,
             parent_vtxindex = block_commit_op.parent_vtxindex
         );

[jferrant]

If we're going to do this, maybe we should also use named parameters when the expression cannot be directly inserted in place. I find it a little less clear when there is a mix of empty {} and those with names in them. For example:

        test_debug!(
             "Miner {miner_id}: Block commit transaction builds on {parent_block_ptr},{parent_vtxindex} (parent snapshot is {parent_block_snapshot_opt:?})",
             miner_id = miner.id,
             parent_block_ptr = block_commit_op.parent_block_ptr,
             parent_vtxindex = block_commit_op.parent_vtxindex
         );

I agree. I think I should do this as well.

I am doing it as a blanket apply across all code, but don't think we have to be super strict about this. By no means should this prevent a PR merging, but I think we as a team should try introducing it as a best practice :)

[jcnelson]

Approving provided all CI tests pass.

[blockstack-devops]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.