Fix typos in codebase #5349
Fix typos in codebase #5349
Conversation
|
|
| @@ -977,7 +977,7 @@ impl SpvClient { | |||
|
|
|||
| // contiguous? | |||
| if block_headers[0].header.prev_blockhash != parent_header.header.bitcoin_hash() { | |||
| warn!("Received discontiguous headers at height {}: we have parent {:?} ({}), but were given {:?} ({})", | |||
| warn!("Received discontinuous headers at height {}: we have parent {:?} ({}), but were given {:?} ({})", | |||
There was a problem hiding this comment.
I think "discontiguous" is correct here.
| @@ -3045,7 +3045,7 @@ impl StacksChainState { | |||
| } | |||
|
|
|||
| if signed_microblocks[0].header.sequence != 0 { | |||
| // discontiguous -- must start with seq 0 | |||
| // discontinuous -- must start with seq 0 | |||
There was a problem hiding this comment.
All uses of "discontiguous" in this file are correct.
| @@ -115,7 +115,7 @@ impl StacksChainState { | |||
| affirmation_weight: u64, | |||
| ) -> Result<(), Error> { | |||
| let StacksBlockHeaderTypes::Epoch2(header) = &tip_info.anchored_header else { | |||
| return Err(Error::InvalidChildOfNakomotoBlock); | |||
| return Err(Error::InvalidChildOfNakamotoBlock); | |||
There was a problem hiding this comment.
See my comment in stackslib/src/chainstate/stacks/mod.rs.
| @@ -126,7 +126,7 @@ pub enum Error { | |||
| MinerAborted, | |||
| ChannelClosed(String), | |||
| /// This error indicates a Epoch2 block attempted to build off of a Nakamoto block. | |||
| InvalidChildOfNakomotoBlock, | |||
| InvalidChildOfNakamotoBlock, | |||
There was a problem hiding this comment.
I'm not sure if it's safe to change this or if it will be consensus-breaking. I'll need to come back to this.
There was a problem hiding this comment.
Hi @obycode ,did you check? I was waiting for your reply.
There was a problem hiding this comment.
Ah, sorry I forgot to follow up. Seems like it should be okay. A block replay always happens before release to be sure, so you can go ahead with this change.
|
Please resolve merge conflicts. |
|
@Parikalp-Bhardwaj please resolve conflicts and remaining comments. |
|
Please merge the latest |
Description
Changes Made
Note: All changes are focused on comments, variable names, and documentation where the typos were present.
Related Issue