Initial expansion of if-brackets in all collector/lib files

[SimonBaeumer]

Description

This PR runs the expand brackets option of the clang-format tool.

I've extracted some other parts of the PR, mainly because the clang-format requires an update. To avoid merge conflicts this PR only provides the initial formatting.

Subsequent PRs:

• Enable flag in clang-format config: Enable InsertBraces in clang-format #1851
• Add init-githooks target: Add init-githooks Makefile target #1850

[Molter73]

Looks good! Thanks for putting this together!

Main concern is that the optionparser.h file shouldn't be formatted, other than that LGTM!

[Molter73]

Looks like CI is using an old version of clang-format, I'm looking into why it's doing that and how we can update it to at least 15.

[Molter73]

Looks like CI is using an old version of clang-format, I'm looking into why it's doing that and how we can update it to at least 15.

Ok, seems there are 2 options here:

• The ubuntu-latest runner which is used in CI has clang-format v13, v14 and v15 already installed in it, so you could go down the rabbit hole that is telling ubuntu to use the right version of clang-format (15 in this case).

  • https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md#language-and-runtime

• Easier alternative, though a bit overkill, you can just update the lint workflow to use ubuntu-24.04 which has clang-format v16, v17 and v18, any of which will work with the new option.

• https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2404-Readme.md#language-and-runtime

[SimonBaeumer]

Looks like CI is using an old version of clang-format, I'm looking into why it's doing that and how we can update it to at least 15.

Ok, seems there are 2 options here:

• The ubuntu-latest runner which is used in CI has clang-format v13, v14 and v15 already installed in it, so you could go down the rabbit hole that is telling ubuntu to use the right version of clang-format (15 in this case).

  • https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md#language-and-runtime

• Easier alternative, though a bit overkill, you can just update the lint workflow to use ubuntu-24.04 which has clang-format v16, v17 and v18, any of which will work with the new option.

• https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2404-Readme.md#language-and-runtime

Tanks for looking it up! I've created a new PR to update the clang-format: #1851

This PR now focuses only on inserting the braces to avoid tedious merge conflicts.

[Molter73]

LGTM!