Fix network worker smoke test #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't bother with stopping every process one by one, correct endpoints gathering from logs and test configuration.
ovalenti
reviewed
Dec 9, 2024
Comment on lines
+25
to
+27
| # start the server before bpftrace, to skip first accept | ||
| echo "Starting the server..." | ||
| berserker tests/workers/network/workload.server.toml &> /tmp/server.log & |
There was a problem hiding this comment.
[nit] Launching in background ('&') does not guarantee the server will have completed initialization before bpftrace is started. This would require that berserker decides when to daemonize to give back control.
There was a problem hiding this comment.
Good point, I'll add some mechanisms to make sure it's fully initialized.
There was a problem hiding this comment.
This is not what I had imagined, but it is simple and should work. Thanks !
ovalenti
approved these changes
Dec 16, 2024
Co-authored-by: Olivier Valentin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't bother with stopping every process one by one, correct endpoints gathering from logs and test configuration.