Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-26276: replace dinosaurs with centrals for cname components #2056

Merged
merged 4 commits into from
Oct 10, 2024

Conversation

johannes94
Copy link
Contributor

@johannes94 johannes94 commented Oct 2, 2024

Description

As a first step for ROX-26276 which requires refactoring of the cname mgr worker I thought it might be beneficial for the code base to replace some dinosaurs.

144 less dinosaurs for this PR 👍

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources
  • (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

CI is sufficient only naming changes for existing components.

Copy link
Collaborator

@ebensh ebensh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's so beautiful :'-)

Copy link
Contributor

openshift-ci bot commented Oct 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ebensh, johannes94

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johannes94 johannes94 force-pushed the jmalsam/replace-dinosaurs-central-cname branch from 77ed17c to 3b06cef Compare October 9, 2024 12:35
@openshift-ci openshift-ci bot removed the lgtm label Oct 9, 2024
Copy link
Contributor

openshift-ci bot commented Oct 9, 2024

New changes are detected. LGTM label has been removed.

@johannes94 johannes94 merged commit da27b68 into main Oct 10, 2024
12 checks passed
@johannes94 johannes94 deleted the jmalsam/replace-dinosaurs-central-cname branch October 10, 2024 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants