-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-26276: replace dinosaurs with centrals for cname components #2056
Conversation
e63fd84
to
1fb2dd0
Compare
1fb2dd0
to
77ed17c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's so beautiful :'-)
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ebensh, johannes94 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
77ed17c
to
3b06cef
Compare
New changes are detected. LGTM label has been removed. |
Description
As a first step for ROX-26276 which requires refactoring of the cname mgr worker I thought it might be beneficial for the code base to replace some dinosaurs.
144 less dinosaurs for this PR 👍
Checklist (Definition of Done)
Test manual
ROX-12345: ...
Test manual
CI is sufficient only naming changes for existing components.