Move auth and client init into BeforeEach to improve Ginkgo errors #1321
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In case the environment in which to execute e2e tests is missing proper auth tokens, executing the e2e tests can fail as follows:
This doesn't point directly to the root cause (missing tokens in environment), instead it tells us to reorganize the test init so that Ginkgo can handle failures gracefully.
This PR follows Ginkgo's advice by moving the potentially panicking code into a
BeforeEach
construct.Checklist (Definition of Done)
Unit and integration tests added(n/a)Documentation added if necessary (i.e. changes to dev setup, test execution, ...)(n/a)Add the ticket number to the PR title if available, i.e.(fix done without ticket)ROX-12345: ...
Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.(n/a)Add secret to app-interface Vault or Secrets Manager if necessary(n/a)RDS changes were e2e tested manually(n/a)Check AWS limits are reasonable for changes provisioning new resources(n/a)Test manual
TODO: Add manual testing efforts