Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsued image/build/local Makefile target #1258

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

SimonBaeumer
Copy link
Member

Description

Remove image/build/local target because it is not used

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources

@SimonBaeumer SimonBaeumer temporarily deployed to development September 13, 2023 14:17 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development September 13, 2023 14:17 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development September 13, 2023 14:17 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer mentioned this pull request Sep 14, 2023
9 tasks
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ebensh, SimonBaeumer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [SimonBaeumer,ebensh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 14, 2023

New changes are detected. LGTM label has been removed.

@SimonBaeumer SimonBaeumer temporarily deployed to development September 14, 2023 09:21 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development September 14, 2023 09:21 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development September 14, 2023 09:21 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer merged commit 761b8aa into main Sep 14, 2023
5 checks passed
@SimonBaeumer SimonBaeumer deleted the sb/remove-local-bui branch September 14, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants