Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change dockerfiles, kubernetes and docker_compose arguments to accept multiple values #25

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Jun 18, 2024

It's not unusual to have multiple dockerfiles spread around the
codebase, so it would be useful to support that. This patch supports a
JSON-like array e.g. ["Dockerfile", "Dockerfile.dev"].

Fixes: #8

… multiple values

It's not unusual to have multiple dockerfiles spread around the
codebase, so it would be useful to support that. This patch supports a
JSON-like array e.g. `["Dockerfile", "Dockerfile.dev"]`.

Fixes: stacklok#8
@jhrozek
Copy link
Contributor Author

jhrozek commented Jun 18, 2024

@puerco @rdimitrov this is not critical for the release but IMO nice to have. I can't make up my mind about the multi-value strings though..the JSON syntax is kinda obvious but also seems to be a bit ugly.

Copy link
Member

@puerco puerco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean the yaml in the workflow configuration? I think it's fine as you don't really need to see it unless you need to change the defaults, or change it to this in the example if it seems less ugly?

dockerfiles:
  - "./Dockerfile"
  - "./images"

@jhrozek
Copy link
Contributor Author

jhrozek commented Jun 19, 2024

You mean the yaml in the workflow configuration? I think it's fine as you don't really need to see it unless you need to change the defaults, or change it to this in the example if it seems less ugly?

dockerfiles:
  - "./Dockerfile"
  - "./images"

The thing is that the workflows don't seem to support any other configuration type than string, int or bool, at least I don't see it the docs

@jhrozek jhrozek merged commit 272ccfd into stacklok:main Jun 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the action config to take list of paths instead of a single one
2 participants