Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove support for Python 3.8 #114

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

philvarner
Copy link

@philvarner philvarner commented Apr 19, 2024

Related Issue(s):

  • n/a

Proposed Changes:

  1. Python 3.8 is EOL this year, so there are no new projects that should be using it, and existing projects don't need to update to the next major-minor.
  2. In the last two changes I've tried to make, I've had incompatibilities with 3.8 that have required a workaround, so supporting it is becoming a burden.

PR Checklist:

  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.

@philvarner philvarner changed the title deprecate support for 3.8 remove support for Python 3.8 Apr 19, 2024
Copy link
Member

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 we dropped it from pystac, where we have the policy of following numpy.

Could add 3.12?

@philvarner
Copy link
Author

Could add 3.12?
It's already in there.

@philvarner philvarner enabled auto-merge (squash) April 22, 2024 12:16
@philvarner philvarner merged commit d416a3b into stac-utils:main Apr 22, 2024
6 checks passed
@philvarner philvarner deleted the pv/deprecate-3.8 branch April 22, 2024 12:26
@gadomski
Copy link
Member

It's already in there.

🤦🏼

@philvarner
Copy link
Author

Also @gadomski, the only reason I was reluctant to remove it was we have this idea that it may be possible to convert an existing container that runs processing (possibly on an older version of Python b/c scientists) into a stactask Task, but I think that's not feasible in most cases, so need to find another way to do that anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants