Update to support .NET Core 3.1 #651
Conversation
|
It would be neat if this PR gets merged. Thank you @darknessxk for your help with this, as I've hit the same issue with this library. |
|
Any news on net core async support? I have tested this pull request and seems to be working fine. ConnectAsync and SendAsync are working with NET core 5.0 |
|
I don't think this will get merged, like ever :( |
| <TargetFrameworkVersion>v3.5</TargetFrameworkVersion> | ||
| <SignAssembly>true</SignAssembly> | ||
| <AssemblyOriginatorKeyFile>websocket-sharp.snk</AssemblyOriginatorKeyFile> | ||
| <TargetFramework>netcoreapp3.1</TargetFramework> |
There was a problem hiding this comment.
Isn't more interesting to replace it with
| <TargetFramework>netcoreapp3.1</TargetFramework> | |
| <TargetFrameworks>netstandard2.0;netstandard2.1</TargetFrameworks> |
There was a problem hiding this comment.
Isn't more interesting to replace it with
Or maybe even better:
<TargetFrameworks>netstandard2.0;net452</TargetFrameworks>
|
I have more than two years using websocketsharp in a .net core 3.1 project, the project is in production since then on Ubuntu 18.04, I have not suffered from any problems. When I read about the project being incompatible it makes me very strange. |
# Conflicts: # Example/Example.csproj # Example/Program.cs # Example2/Chat.cs # Example2/Echo.cs # Example2/Program.cs # Example3/Chat.cs # Example3/Echo.cs # Example3/Program.cs # websocket-sharp.sln # websocket-sharp/Net/HttpStreamAsyncResult.cs # websocket-sharp/WebSocket.cs
Pulls/1335341197/1
|
@sta any updates? |
Changed the BeginInvoke and EndInvoke calls to proper async Tasks usages