-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add interactive sst-info #1011
Add interactive sst-info #1011
Conversation
SST Master Branch Merger: Auto Create Pull Request to Promote from devel to master - All Tests Ran Clean
Automatically Merged using SST Master Branch Merger
Automatically Merged using SST Master Branch Merger
Automatically Merged using SST Master Branch Merger
Automatically Merged using SST Master Branch Merger
Automatically Merged using SST Master Branch Merger
Automatically Merged using SST Master Branch Merger
Automatically Merged using SST Master Branch Merger
Automatically Merged using SST Master Branch Merger
Automatically Merged using SST Master Branch Merger
Automatically Merged using SST Master Branch Merger
Automatically Merged using SST Master Branch Merger
Automatically Merged using SST Master Branch Merger
Automatically Merged using SST Master Branch Merger
Automatically Merged using SST Master Branch Merger
Automatically Merged using SST Master Branch Merger
CMAKE-FORMAT TEST - PASSED |
CLANG-FORMAT TEST - FAILED (on last commit): |
CLANG-FORMAT TEST - PASSED |
CMAKE-FORMAT TEST - PASSED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally things look good, but we need to bracket all the new code in #ifdefs that ensure that ncurses is installed. That way if there's a machine that doesn't have it installed for some reason, sst will still compile.
CLANG-FORMAT TEST - PASSED |
CMAKE-FORMAT TEST - PASSED |
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
CLANG-FORMAT TEST - PASSED |
CMAKE-FORMAT TEST - PASSED |
@feldergast I've added in the #ifdefs and the error messages from the other PR. However, do you know if the code would actually configure and compile correctly without curses due to the changed code in
|
CLANG-FORMAT TEST - PASSED |
CMAKE-FORMAT TEST - PASSED |
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
Going to go ahead and close this PR and try again |
Adding first version of interactive SST-info, activated using flag
-i
/--interactive