P95 #1008
Draft
P95 #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1008 +/- ##
=======================================
Coverage 83.84% 83.85%
=======================================
Files 196 196
Lines 5517 5519 +2
Branches 1199 1201 +2
=======================================
+ Hits 4626 4628 +2
Misses 857 857
Partials 34 34
☔ View full report in Codecov by Sentry. |
sspenst
reviewed
Oct 3, 2023
| count: { $sum: 1 } | ||
| } | ||
| }, | ||
| { |
There was a problem hiding this comment.
Can we combine sumDuration and sumDurationP95? Should have all the data for sumDuration at this point
There was a problem hiding this comment.
actually i realized when trying to do this that this is risky and not actually as straightforward since i do a bunch of groups. probably safer for now to keep it separate
sspenst
added a commit
that referenced
this pull request
Oct 4, 2023
|
Converted to draft because we would need to figure out an efficient way to handle updates to the P95 difficulty value (queuing every playattempt request may be too much). Alternatively I'm not sure how worth it this change is for difficulty accuracy. It may be worth running a script to find the largest changes in difficulty with this value and seeing if they are expected / better than what we have. |
sspenst
added a commit
that referenced
this pull request
Oct 4, 2023
sspenst
added a commit
that referenced
this pull request
Oct 4, 2023
* next-themes wip * signup toast and game.tsx change * nuke newrelic frontend because possible memory issue on windows * update git ignore, add public/sounds/music * /campaign perf. From ~1.1s load to about 200ms * fix test * cleanup * reset leastMoves on unpublish * post level modal and tooltips (#1000) * post level modal and tooltips * wip * revert collection-by-id * updates * delete capitalized file * PR todos done * cleanup * fix build * useeffect for query params * tweaks * simplify --------- Co-authored-by: Spencer Spenst <[email protected]> * ch4 preview (#1006) * collection-by-id aggregate (#1003) * wip * fix issue with collection ordering * fix test * improve getCollection across website * improving agg for edit levels * rename * improve profile collections loading by ~25% * fix some issues with getCollections * fix tests * fix bug found from broken test. * knock another 100ms off profile load * 👍 * forgot 1 file --------- Co-authored-by: Danny Miller <[email protected]> * postgamemodal improvements * more intuitive campaign button * login link for some tips * [Snyk] Upgrade pureimage from 0.3.17 to 0.4.7 (#977) * fix: upgrade pureimage from 0.3.17 to 0.4.7 Snyk has created this PR to upgrade pureimage from 0.3.17 to 0.4.7. See this package in npm: https://www.npmjs.com/package/pureimage See this project in Snyk: https://app.snyk.io/org/k2xl/project/cf09253a-8e4c-4f7f-b75f-a1763e5c78eb?utm_source=github&utm_medium=referral&page=upgrade-pr * pureimage type declaration * fix --------- Co-authored-by: snyk-bot <[email protected]> Co-authored-by: Spencer Spenst <[email protected]> * add reviews and 'dont show this popup for 24h' checkbox * getRecommendedLevel dont show a level they have played recently * get rid of datetime filter * Tweak. Remove unnecessary colon * complete/incomplete filter button for chapters * indicators for marking ready * tooltip for checkpoint * cleanup * disable useswr unless popup is open * share icons on post modal * sharebar * curator edit/delete reviews (#1009) * curator edit/delete reviews * red ellipsis * test * fix flaky tests * merge * clear review rating button * curator level management ux * delete achievements on user delete * use level userId instead of req userId * move add to/edit level out of header dropdown * hotfix for deleted reviews on home page * achievement page (#1005) * i forgot i had made this page on a branch when we did achievements * tweak --------- Co-authored-by: Spencer Spenst <[email protected]> * update calc_records on archive * Revert "update calc_records on archive" This reverts commit 06f89c8. * Try to get twitter images to show * change to twitter site for card... * apparently twitter now requires full url for og image * also do ogurl just in case * mobile buttons update (#1011) * mobile buttons update * optimizations * mobile tweaks --------- Co-authored-by: Spencer Spenst <[email protected]> * integrityCheckRecords * more accurate preventKeyDownEvent * multiSelectLevel (from #1008) * handle app theme in theme modal * use dark class condition instead of checking theme --------- Co-authored-by: Danny Miller <[email protected]> Co-authored-by: snyk-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.