Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forward API documentation ref to ssb-db for up to date #702

Merged
merged 2 commits into from
Nov 20, 2019

Conversation

Connoropolous
Copy link
Contributor

@Connoropolous Connoropolous commented Nov 20, 2019

I did a manual diff comparison between the two, and saw that in ssb-db only additions were made. There was nothing in this file that wasn't there, but the opposite was not true. There are new things there:
This was the whole diff
Screen Shot 2019-11-20 at 10 17 17 AM

By the way, there wasn't even a link to this file in the README here, so I'm being even on the precocious side by even leaving this file.

@christianbundy
Copy link
Contributor

Nice! I think we can probably just rip this file out completely, what do you think? Happy to merge as-is or with a more aggressive deletion.

Context: I'm guessing that at one point we used this with mdmanifest, which created a muxrpc manifest file from a Markdown file like api.md.

@Connoropolous
Copy link
Contributor Author

Ok let's just delete, I agree

This was proposed by @christianbundy in the PR review
@christianbundy christianbundy merged commit c66ecf9 into ssbc:master Nov 20, 2019
@mixmix
Copy link
Member

mixmix commented Nov 21, 2019

HOORAY!

@Connoropolous
Copy link
Contributor Author

Yeah, we are down to 3 competing API references only now :)

@Connoropolous
Copy link
Contributor Author

#705 is a discussion on how to drop that further, along with the issue in ssb-db that it links to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants