Adjust tests to new fixtures #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Powersource
commented
Jan 22, 2024
| @@ -69,7 +69,7 @@ test('exact chain-of-words', (t) => { | |||
| pull.filter((msg) => msg.value.content.text.toLowerCase().includes(INPUT)), | |||
| pull.collect((err, msgs) => { | |||
| t.error(err, 'no error'); | |||
| t.equals(msgs.length, 4, 'four posts'); | |||
| t.equals(msgs.length, 2, 'two posts'); | |||
There was a problem hiding this comment.
% rg -a 'labore officia exercitation' /tmp/ssb-search2/flume/log.offset|wc -l
2(there are multiple messages on each line but i verified by looking at the results in less)
There was a problem hiding this comment.
tried finding a search with a few more results but i could only find searches with either 1-2 results or like 30+ (which would be harder to verify)
Powersource
commented
Jan 22, 2024
Comment on lines
-94
to
+96
| t.equals(matches.length, 3, '3 matches'); | ||
| t.equals(matches.length, 2, '2 matches'); | ||
| const matchPositions = matches.map((m) => m.index); | ||
| t.deepEquals(matchPositions, [47, 55, 168], 'labo positions found'); | ||
| t.deepEquals(matchPositions, [160, 168], 'labo positions found'); |
There was a problem hiding this comment.
i think this is the message it's running on
{"key":"%rEpV0vnOoBuO01jmBb90H4Af/FmxTasGV0+otihgN8s=.sha256","value":{"previous":null,"sequence":1,"author":"@J74J+ctsqJNREBjVqvc/oeSVWNRrGcrfH54ERGQtqwI=.ed25519","timestamp":17059425
45831,"hash":"sha256","content":{"type":"post","text":"OLDESTMSG reprehenderit officia ad","c
hannel":"mollit","mentions":[{"link":"@3rJVBV5zDW8wgCEjAHBgNAkiE2c+HJf2XIsU6aND3Z8=.ed25519","name":"laborum laboris reprehenderit"},{"link":"&ZGVzZXJ1bnRsYWJvcmVvY2NhZWNhdGR1aXNuaXNpZXg=.sha256","type":"image/png","size":1220163},{"link":"@n7mkSt+3MKjSP5S8R6lJx2ixZKefldZ8GuyyBbtNCY4=.ed25519","name":"magna est"},{"link":"@QxRm+ZF6ZmZtMRDbdTvSL5FVG8XjiP0m5qHqRnSIacI=.ed25519","name":"nostrud"}]},"signature":"BAiI3JmQM7ZVkZbQdvLvHIFTgM2zltmUHzcxRF9kkQpLPcKvSTbbaH67Hl0i1XHBgb5vzNUltDoV57iRMjzaAA==.sig.ed25519"},"timestamp":1705942545832}the matching text seems to be at sort of 160 and 168 chars into the content so it's probably ok? this is a bit more of a hunch on my part, idk exactly what .index is.
There was a problem hiding this comment.
I don't know either what's going on, but it's fine by me 🤷
staltz
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3
So I did https://github.com/ssbc/ssb-search2/pull/2/files and there were failing tests in ci but i was like pfft silly CI. Turns out my machine didn't get the new, different fixtures (had to upgrade ssb-fixtures because of rsjs). So this PR adjusts the tests to actually pass with the new fixtures