Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A test flaking #3

Closed
Powersource opened this issue Jan 22, 2024 · 2 comments · Fixed by #4
Closed

A test flaking #3

Powersource opened this issue Jan 22, 2024 · 2 comments · Fixed by #4

Comments

@Powersource
Copy link
Contributor

After this PR it's passing locally but failing on one test in CI #2 (not sure what was the status before the PR, it couldn't install for me)
@Powersource
Copy link
Contributor Author

oh gdi now got it to fail locally too. i guess some race condition/flake. hopefully not a problem in real life scenarios

exact chain-of-words

    ✔ no error

    ✖ four posts
    -------------
      operator: equal
      expected: 4
      actual:   2
      at: <anonymous> (/home/me/prj/ssb/ssb-search2/test/index.js:72:9)
      stack: |-
  Error: four posts
  at Test.assert [as _assert] (/home/me/prj/ssb/ssb-search2/node_modules/.pnpm/[email protected]/node_modules/tape/lib/test.js:310:54)
  at Test.bound [as _assert] (/home/me/prj/ssb/ssb-search2/node_modules/.pnpm/[email protected]/node_modules/tape/lib/test.js:91:32)
  at Test.strictEqual (/home/me/prj/ssb/ssb-search2/node_modules/.pnpm/[email protected]/node_modules/tape/lib/test.js:474:10)
  at Test.bound [as equals] (/home/me/prj/ssb/ssb-search2/node_modules/.pnpm/[email protected]/node_modules/tape/lib/test.js:91:32)
  at /home/me/prj/ssb/ssb-search2/test/index.js:72:9
  at /home/me/prj/ssb/ssb-search2/node_modules/.pnpm/[email protected]/node_modules/pull-stream/sinks/reduce.js:10:5
  at /home/me/prj/ssb/ssb-search2/node_modules/.pnpm/[email protected]/node_modules/pull-stream/sinks/drain.js:20:24
  at /home/me/prj/ssb/ssb-search2/node_modules/.pnpm/[email protected]/node_modules/pull-stream/throughs/filter.js:17:11
  at /home/me/prj/ssb/ssb-search2/node_modules/.pnpm/[email protected]/node_modules/pull-stream/throughs/flatten.js:35:20
  at /home/me/prj/ssb/ssb-search2/node_modules/.pnpm/[email protected]/node_modules/pull-stream/throughs/map.js:19:9

@Powersource Powersource changed the title A test failing in CI A test flaking Jan 22, 2024
@Powersource
Copy link
Contributor Author

the first 'generate fixture' test just seems to be a setup thing. if it's run once it doesn't run again. maybe i did: 1. run generate with old ssb-fixtures version 2. update ssb-fixtures with actual breaking changes 3. run stuff with the new ssb-fixtures version but with fixtures from the old version. Now that I've rebooted i lost the old fixtures and got new ones, just like ci

@Powersource Powersource mentioned this issue Jan 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adjust tests to new fixtures ssbc/ssb-search2
1 participant
@Powersource