Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: in nodejs mobile we were getting an app crash on using an invite:
Tracked this down into
muxrpc
and I think what's happening is a race condition aroundps
andws
closing. We were only seeing this crash when Ben (in Colombia) was trying to use an invite to my pub in New Zealand 😢 (no such problems in NZ peer -> NZ pub)ANYWAY the
throw
is happening because there is nocb
being provided on close. So I've provided a callback ...