Add Hook to compat functions #424
Conversation
Add Hook to compat functions Co-Authored-By: Mix Irving<[email protected]>
|
heey cool :) could we get a test though |
|
or maybe if we do this same pattern in other files it'd maybe not be needed |
|
@Powersource this was Zach and I pairing in this area. Assume he's not coming back to this PR, then decide how you'd like to proceed. If this PR is still needed (I think this mainly exists to make testing some things easier), then can you take it over and pull me if any help needed ? |
|
yeah i think stuff like ssb-recps-guard needs this (if it detects ssb.publish it tries to hook it) |
| sbot.whoami = () => ({ id: sbot.id }) | ||
| sbot.ready = () => true | ||
| }) | ||
| sbot.publish = Hookable(sbot.db.publish) |
There was a problem hiding this comment.
sbot.db.publish is created by the publish compat plugin. i wonder if this throws if we don't load that first?
There was a problem hiding this comment.
made a new PR with some changes, didn't want to juggle the branches around #427
|
gonna merge that other PR |
|
v8.1.0 |
No description provided.