Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Update npm dependencies #975

Merged
merged 5 commits into from
Apr 4, 2019
Merged

Update npm dependencies #975

merged 5 commits into from
Apr 4, 2019

Conversation

christianbundy
Copy link
Contributor

@christianbundy christianbundy commented Mar 27, 2019

Woo! This brings us up-to-date almost everywhere and everything seems to be working great.

The only packages left behind:

I've manually researched each major/non-semver change and couldn't find any compatibility issues. I've also checked the interface to ensure that everything is still working an it's all running as expected.

@mmckegg
Copy link
Contributor

mmckegg commented Apr 1, 2019

@christianbundy when I try and run npm install on this I get:

$ npm install
npm ERR! code ENOLOCAL
npm ERR! Could not install from "node_modules/electron-spellchecker/@paulcbetts/cld@github:ssbc/paulcbetts-cld-prebuilt" as it does not contain a package.json file.

Same even after running rm -rf node_modules.

More errors later on if I run npm ci:

> [email protected] install /Users/matt/Code/patchwork/node_modules/mouse-forward-back
> node-gyp rebuild
gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
  CXX(target) Release/obj.target/mouse-forward-back/mouse-forward-back.o
../mouse-forward-back.cc:3:10: fatal error: 'X11/Xlib.h' file not found
#include <X11/Xlib.h>
         ^~~~~~~~~~~~
1 error generated.
make: *** [Release/obj.target/mouse-forward-back/mouse-forward-back.o] Error 1
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/Users/matt/.npm-global/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:262:23)

For some reason, all of these errors disappear if I delete the package-lock file. Here's my regenerated package-lock for reference: package-lock.json.zip

Copy link
Contributor

@mmckegg mmckegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mmckegg mmckegg merged commit 383d4b2 into master Apr 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants