Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

color speaker names in local chat channel as their corresponding runechat name #965

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Gaxeer
Copy link
Collaborator

@Gaxeer Gaxeer commented Jan 11, 2025

Что этот PR делает

Красит имя в локальном в чате, в зависимости от цвета присвоенного к рунчату моба

Почему это хорошо для игры

Легче понимать кто говорит вчат

Изображения изменений

image

Тестирование

запустил, проверил

Changelog

🆑
add: Красит имя в локальном в чате, в зависимости от цвета присвоенного к рунчату моба
/:cl:

Copy link

sourcery-ai bot commented Jan 11, 2025

Reviewer's Guide by Sourcery

This PR changes the color of speaker names in the local chat channel to match their corresponding runechat name color. This is done by adding a tag with a style attribute containing the speaker's chat color around the speaker's name.

Sequence diagram for colored chat name processing

sequenceDiagram
    participant User as User
    participant Game as Game System
    participant Speaker as Speaker Object
    participant Chat as Chat Display

    User->>Game: Says something in local chat
    Game->>Speaker: Get speaker name (GetVoice/stored_name)
    Speaker-->>Game: Return speaker name
    Game->>Speaker: Get chat_color
    Speaker-->>Game: Return chat color
    Game->>Chat: Display message with colored name
    Note over Chat: Name wrapped in span tag<br/>with speaker's chat color
Loading

File-Level Changes

Change Details Files
Added a span tag to change the speaker's name color in local chat.
  • Wrapped the speaker's name in a tag with a style attribute set to 'color: [speaker.chat_color]'.
  • Replaced the hardcoded speaker name with a reference to the speaker's chat color from the runechat mob.
code/game/say.dm

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@dj-34 dj-34 added the 🔬 Testmerge Active Находится в тестмерже на сервере label Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔬 Testmerge Active Находится в тестмерже на сервере
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants