Skip to content

Commit

Permalink
Merge upstream [29.12.2024] (#935)
Browse files Browse the repository at this point in the history
## About The Pull Request

Merge upstream [29.12.2024]
  • Loading branch information
Gaxeer authored Dec 29, 2024
2 parents 4996117 + c2622d3 commit 084867b
Show file tree
Hide file tree
Showing 266 changed files with 5,867 additions and 4,420 deletions.
6 changes: 5 additions & 1 deletion .github/alternate_byond_versions.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,11 @@
# This is useful for making sure we maintain compatibility with both older and newer versions,
# while still having our main tests run on a guaranteed pinned version.

# Format is version: map
# Format is "version: map" or "version: map;max_required_client_version"
# Example:
# 500.1337: runtimestation
# 516.1638: runtimestation;516
# Lowest supported version
515.1627: runtimestation
# Beta version
516.1648: runtimestation;516
2 changes: 0 additions & 2 deletions .github/guides/STANDARDS.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,6 @@ var/path_type = "/obj/item/baseball_bat"

* You are expected to help maintain the code that you add, meaning that if there is a problem then you are likely to be approached in order to fix any issues, runtimes, or bugs.

* Do not divide when you can easily convert it to multiplication. (ie `4/2` should be done as `4*0.5`)

* Separating single lines into more readable blocks is not banned, however you should use it only where it makes new information more accessible, or aids maintainability. We do not have a column limit, and mass conversions will not be received well.

* If you used regex to replace code during development of your code, post the regex in your PR for the benefit of future developers and downstream users.
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ci_suite.yml
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ jobs:
- name: Find Alternate Tests
id: alternate_test_finder
run: |
ALTERNATE_TESTS_JSON=$(jq -nRc '[inputs | capture("^(?<major>[0-9]+)\\.(?<minor>[0-9]+): (?<map>.+)$")]' .github/alternate_byond_versions.txt)
ALTERNATE_TESTS_JSON=$(jq -nRc '[inputs | capture("^(?<major>[0-9]+)\\.(?<minor>[0-9]+): (?<map>[^;]+);?(?<max_client_version>[0-9]+)?$")]' .github/alternate_byond_versions.txt)
echo "alternate_tests=$ALTERNATE_TESTS_JSON" >> $GITHUB_OUTPUT
- name: Collect byond client version configuration
id: max_required_byond_client
Expand Down Expand Up @@ -223,7 +223,7 @@ jobs:
map: ${{ matrix.setup.map }}
major: ${{ matrix.setup.major }}
minor: ${{ matrix.setup.minor }}
max_required_byond_client: ${{needs.collect_data.outputs.max_required_byond_client}}
max_required_byond_client: ${{ matrix.setup.max_client_version || needs.collect_data.outputs.max_required_byond_client }}

compare_screenshots:
if: needs.collect_data.outputs.alternate_tests == '[]' || needs.run_alternate_tests.result == 'success'
Expand Down
2 changes: 1 addition & 1 deletion _maps/RandomRuins/SpaceRuins/bigderelict1.dmm
Original file line number Diff line number Diff line change
Expand Up @@ -584,7 +584,7 @@
name = "dried blood trail"
},
/mob/living/basic/creature{
desc = "Awh its so sm-OH GOD WHAT THE FUCK.";
desc = "Awh, it's so sm-OH GOD, WHAT THE FUCK.";
health = 25;
maxHealth = 25;
name = "hatchling";
Expand Down
14 changes: 7 additions & 7 deletions _maps/map_files/Birdshot/birdshot.dmm
Original file line number Diff line number Diff line change
Expand Up @@ -20930,6 +20930,7 @@
},
/obj/machinery/vending/boozeomat,
/obj/effect/turf_decal/siding/wood,
/obj/structure/sign/warning/no_smoking/circle/directional/north,
/turf/open/floor/iron/dark/diagonal,
/area/station/service/bar)
"hsC" = (
Expand Down Expand Up @@ -30567,11 +30568,6 @@
/obj/effect/turf_decal/siding/wood{
dir = 1
},
/obj/machinery/barsign{
chosen_sign = "thecavern";
icon_state = "thecavern";
pixel_y = 32
},
/obj/machinery/reagentgrinder{
pixel_x = -5;
pixel_y = 10
Expand Down Expand Up @@ -33247,10 +33243,14 @@
pixel_x = -7;
pixel_y = 15
},
/obj/structure/sign/warning/no_smoking/circle/directional/north,
/obj/effect/turf_decal/siding/wood/end{
dir = 8
},
/obj/machinery/barsign{
chosen_sign = "thecavern";
icon_state = "thecavern";
pixel_y = 32
},
/turf/open/floor/iron/dark/diagonal,
/area/station/service/bar)
"lnI" = (
Expand Down Expand Up @@ -58691,7 +58691,7 @@
},
/obj/machinery/chem_dispenser/drinks/beer,
/obj/effect/turf_decal/siding/wood,
/obj/machinery/digital_clock/directional/north,
/obj/structure/fish_mount/bar/directional/north,
/turf/open/floor/iron/dark/diagonal,
/area/station/service/bar)
"tVt" = (
Expand Down
Loading

0 comments on commit 084867b

Please sign in to comment.