Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove screenshot compare test #1045

Closed

Conversation

AyIong
Copy link
Collaborator

@AyIong AyIong commented Jan 22, 2025

Что этот PR делает

Удаляет тест скриншотов, он у нас вечно почему-то падает, без видимых на то причин
В целом я не думаю что он нам нужен и будет как-то полезен

Почему это хорошо для игры

Галочка в тестах

Summary by Sourcery

Remove the screenshot comparison test from the CI workflow.

CI:

  • Remove screenshot tests from CI.

Tests:

  • Remove screenshot comparison tests.

Copy link

sourcery-ai bot commented Jan 22, 2025

Reviewer's Guide by Sourcery

This pull request removes the screenshot comparison test from the CI pipeline. The test was unreliable and not considered useful.

Flow diagram showing the CI pipeline changes

graph TD
    A[Start CI] --> B[Collect Data]
    B --> C[Run All Tests]
    B --> D[Run Alternate Tests]
    C & D --> E[Windows Build]
    style F fill:#ffcccc,stroke:#ff0000,stroke-dasharray: 5 5
    F[Screenshot Compare Test] -->|Removed| E
    E --> G[End CI]

    subgraph Removed Component
    F
    end
Loading

File-Level Changes

Change Details Files
Removed the screenshot comparison test job from the CI workflow.
  • Removed the 'compare_screenshots' job from the workflow.
  • Removed the steps related to downloading, setting up, and running the screenshot comparison.
  • Removed the steps for saving the PR ID and uploading bad screenshots.
.github/workflows/ci_suite.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ss220app ss220app bot added the 📜 CL валиден Этот чейнджлог будет успешно опубликован label Jan 22, 2025
@AyIong AyIong added 📜 CL не требуется Эти изменения не влияют на игровой процесс или игроки по какой-то причине не должны о них знать and removed 📜 CL валиден Этот чейнджлог будет успешно опубликован labels Jan 22, 2025
@Gaxeer
Copy link
Collaborator

Gaxeer commented Jan 22, 2025

Это нам надо. Надо починить

@Gaxeer Gaxeer closed this Jan 22, 2025
@AyIong AyIong deleted the remove-screenshot-compare-test branch January 22, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 CL не требуется Эти изменения не влияют на игровой процесс или игроки по какой-то причине не должны о них знать
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants