Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more logs #1042

Closed
wants to merge 4 commits into from
Closed

add more logs #1042

wants to merge 4 commits into from

Conversation

Gaxeer
Copy link
Collaborator

@Gaxeer Gaxeer commented Jan 21, 2025

Что этот PR делает

Добавляет больше админских логов

Summary by Sourcery

Add logs for arcade machine prizes and placing floor tiles.

New Features:

  • Log arcade machine prize distribution.
  • Log when a user places a floor tile.

Copy link

sourcery-ai bot commented Jan 21, 2025

Reviewer's Guide by Sourcery

This pull request adds admin logging for arcade prize dispensing and tile placement.

Sequence diagram for arcade prize dispensing with new logging

sequenceDiagram
    actor User
    participant Arcade
    participant LogSystem
    participant AdminSystem

    User->>Arcade: Wins game
    alt 1 in a million chance
        Arcade->>LogSystem: Log pulse rifle prize
        Arcade->>AdminSystem: Notify admins
        Arcade-->>User: Dispense pulse rifle
    else normal prize
        Arcade->>LogSystem: Log regular prize
        Arcade->>AdminSystem: Notify admins
        Arcade-->>User: Dispense regular prize
    end
Loading

Sequence diagram for tile placement with new logging

sequenceDiagram
    actor User
    participant Tile
    participant LogSystem
    participant AdminSystem

    User->>Tile: Place tile
    Tile->>LogSystem: Log tile placement
    Tile->>AdminSystem: Notify admins
    Tile-->>User: Complete placement
Loading

File-Level Changes

Change Details Files
Added logging for when a player obtains a prize from an arcade machine.
  • Added a log to the game log when a player obtains a prize from an arcade machine.
  • Added a message to admins when a player obtains a prize from an arcade machine.
code/game/machinery/computer/arcade/_arcade.dm
Added logging for when a player places a tile.
  • Added a log to the game log when a player places a tile.
  • Added a message to admins when a player places a tile.
code/game/objects/items/stacks/tiles/tile_types.dm

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ss220app ss220app bot added the 📜 CL невалиден Этот чейнджлог не пройдет валидацию перед публикацией. Исправить или удалить, если не требуется label Jan 21, 2025
@dj-34 dj-34 added 🛑 Do Not Merge Почему это висит лучше уточнить в дискорде. 220 проклятий тому кто зальёт это! 📜 CL не требуется Эти изменения не влияют на игровой процесс или игроки по какой-то причине не должны о них знать and removed 📜 CL невалиден Этот чейнджлог не пройдет валидацию перед публикацией. Исправить или удалить, если не требуется labels Jan 21, 2025
@Gaxeer Gaxeer added the 🔬 Testmerge Active Находится в тестмерже на сервере label Jan 23, 2025
@Gaxeer
Copy link
Collaborator Author

Gaxeer commented Jan 24, 2025

Негодяй пойман

@Gaxeer Gaxeer closed this Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔬 Testmerge Active Находится в тестмерже на сервере 📜 CL не требуется Эти изменения не влияют на игровой процесс или игроки по какой-то причине не должны о них знать 🛑 Do Not Merge Почему это висит лучше уточнить в дискорде. 220 проклятий тому кто зальёт это!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants