Remove ternary usage from ru jobs (#349)

## About The Pull Request Убирает тернарник, который и длиннее альтернативы, и вносил бы изменения в количество строк
ss220club · Jul 12, 2024 · 6a2d24b · 6a2d24b
1 parent ef649bb
commit 6a2d24b
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 14 deletions.
diff --git a/tgui/packages/tgui/interfaces/JobSelection.tsx b/tgui/packages/tgui/interfaces/JobSelection.tsx
@@ -86,11 +86,9 @@ export const JobEntry = (data: {
       <>
         {jobIcon && <Icon name={jobIcon} />}
         {job.command ? (
-          <b>{JOBS_RU[jobName] ? JOBS_RU[jobName] : jobName}</b>
-        ) : JOBS_RU[jobName] ? (
-          JOBS_RU[jobName]
+          <b>{JOBS_RU[jobName] || jobName}</b>
         ) : (
-          jobName
+          JOBS_RU[jobName] || jobName
         )}
         <span
           style={{
@@ -150,9 +148,7 @@ export const JobSelection = (props) => {
                   <StyleableSection
                     title={
                       <>
-                        {DEPARTMENTS_RU[departmentName]
-                          ? DEPARTMENTS_RU[departmentName]
-                          : departmentName}
+                        {DEPARTMENTS_RU[departmentName] || departmentName}
                         <span
                           style={{
                             fontSize: '1rem',

diff --git a/tgui/packages/tgui/interfaces/NtosCrewManifest.jsx b/tgui/packages/tgui/interfaces/NtosCrewManifest.jsx
@@ -25,11 +25,7 @@ export const NtosCrewManifest = (props) => {
             <Section
               key={department}
               level={2}
-              title={
-                DEPARTMENTS_RU[department]
-                  ? DEPARTMENTS_RU[department]
-                  : department
-              }
+              title={DEPARTMENTS_RU[department] || department}
             >
               <Table>
                 {entries.map((entry) => (

diff --git a/tgui/packages/tgui/interfaces/PreferencesMenu/JobsPage.tsx b/tgui/packages/tgui/interfaces/PreferencesMenu/JobsPage.tsx
@@ -238,7 +238,7 @@ const JobRow = (props: { className?: string; job: Job; name: string }) => {
               paddingLeft: '0.3em',
             }}
           >
-            {JOBS_RU[name] ? JOBS_RU[name] : name}
+            {JOBS_RU[name] || name}
           </Stack.Item>
         </Tooltip>
 
@@ -318,7 +318,7 @@ const JoblessRoleDropdown = (props) => {
 
   const options = [
     {
-      displayText: `Присоединиться за ${JOBS_RU[data.overflow_role] ? JOBS_RU[data.overflow_role] : data.overflow_role} если не удалось войти`,
+      displayText: `Присоединиться за ${JOBS_RU[data.overflow_role] || data.overflow_role} если не удалось войти`,
       value: JoblessRole.BeOverflow,
     },
     {