Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: switch to pnpm #450

Merged
merged 3 commits into from
Aug 11, 2023
Merged

build: switch to pnpm #450

merged 3 commits into from
Aug 11, 2023

Conversation

MindTooth
Copy link
Member

@MindTooth MindTooth commented Aug 10, 2023 •
edited
Loading

I see a lot of projects doing the change, and I see why not. I experience it to be a lot faster locally too.

@MindTooth MindTooth added the enhancement New feature or request label Aug 10, 2023
@MindTooth MindTooth requested a review from roosta August 10, 2023 14:13
@MindTooth MindTooth force-pushed the build/use_pnpm branch 3 times, most recently from 542e8ee to 30171b6 Compare August 10, 2023 14:40
@MindTooth MindTooth mentioned this pull request Aug 10, 2023
Merged
@MindTooth MindTooth self-assigned this Aug 10, 2023
roosta
roosta approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@roosta roosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm always a bit skeptical of a new npm implementation, I feel like there's a new one now and again, and that they fix some non-existing issue for me. Hopefully this wont bite back later :)

@MindTooth
Copy link
Member Author

Yeah. 😅 I felt this was a validation for a change. renovatebot/renovate#23664

@MindTooth MindTooth merged commit 0641340 into master Aug 11, 2023
1 check passed
@MindTooth MindTooth deleted the build/use_pnpm branch August 11, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roosta roosta roosta approved these changes

Assignees

@MindTooth MindTooth

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MindTooth @roosta