Feat/octocat #444
Merged
Feat/octocat #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So previously the header was repeated in each index, which was ok, but now as I plan to add more common elements templating makes more sense so I've setup handlebars. I've also converted the header part of each page to a partial that accepts arguments, that decide if the header text should be colored or not.
Preview doesn't build anything, it just serves the dist folder if its built. Clarify that in the instructions.
MindTooth
approved these changes
Aug 9, 2023
Co-authored-by: Birger J. Nordølum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore the branch name, I didn't actually add any footer, wasn't sure if you were on that @MindTooth.
Changes
Note
I've setup handlebars, there started to be a lot of repeated html, so I've setup a
src/partials/header.htmlpartial, and asrc/partials/octocat.htmlpartial so these two elements can be included in all the pages.Makes it a bit easier to include a footer as well.