Switched CLI to Cement and improved error handling + logging facilities (fixes #216 and fixes #219) #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added super minimal cement-based CLI * added basic bug list command to cement CLI * added -q option to bug list command * updated force parameter to True for bug download * added upload and download commands to bug CLI * updated BugManager to set force to True * added uninstall command to cement CLI * added bug coverage method to cement CLI * added bug validate command to cement CLI * added commented-out code for --installed and --uninstalled flags to bug list command * added basic source group to cement CLI * added source add command to cement CLI * added source update command to cement CLI * added __delitem__ to source manager * added source remove command to cement CLI * ported tool commands to cement CLI * ported container commands to cement CLI * finished porting existing CLI to cement
ChrisTimperley
changed the title
ChrisTimperley
changed the title
ChrisTimperley
changed the title
ChrisTimperley
changed the title
afsafzal
reviewed
Oct 31, 2018
| tool = tools[name_tool] | ||
| except KeyError: | ||
| raise exceptions.ToolNotFound(name_tool) | ||
| tools.uninstall(tool, force=force) |
There was a problem hiding this comment.
Does this also removes the image? I was never a fan of build and uninstall. It should either be install and uninstall or build and remove.
There was a problem hiding this comment.
Fair point. So, we don't use install any more because it's not clear whether the image is being downloaded or built from scratch. That does make uninstall a weird verb; remove is a better alternative. 👍
There was a problem hiding this comment.
Okay. I've renamed tool uninstall with tool rm and tool remove, and bug uninstall with bug rm and bug remove.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
argparsetocement.~/.bugzoo/logs