Create a friends configuration to use internals. #8651
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From https://www.liutikas.net/2025/01/12/Kotlin-Library-Friends.html we should avoid using @file:Suppress("INVISIBLE_MEMBER", "INVISIBLE_REFERENCE") So instead lets just be friends.
|
One reference left in okhttp.android.test.AndroidAsyncDnsTest To follow up |
JakeWharton
approved these changes
Jan 21, 2025
| api(projects.okhttp) | ||
| "friends"(projects.okhttp) |
There was a problem hiding this comment.
Seems like this requires two configurations: implementationFriend and apiFriend. Otherwise you are changing the visibility of the transitive dependency, as evidence by all the unrelated changes below where you are having to add the dependency yourself when it should be automatically available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From https://www.liutikas.net/2025/01/12/Kotlin-Library-Friends.html we should avoid using
@file:Suppress("INVISIBLE_MEMBER", "INVISIBLE_REFERENCE")
So instead lets just be friends.