Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on unused ESLint disable directives in base config #829

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

bmish
Copy link
Collaborator

@bmish bmish commented Jan 12, 2023

We already suggested this in the README, but we can actually ensure it's enabled for everybody in our shared configs.

Note that it is only possible to warn with this feature (erroring not possible yet, although I've written an RFC regarding this: eslint/rfcs#100).

https://eslint.org/docs/latest/user-guide/configuring/rules#report-unused-eslint-disable-comments

@bmish bmish added the breaking Breaking changes for major releases label Jan 12, 2023
@bmish bmish force-pushed the reportUnusedDisableDirectives-config branch 2 times, most recently from 9ec0fd8 to 39bc9a0 Compare January 12, 2023 16:43
@bmish bmish force-pushed the reportUnusedDisableDirectives-config branch from 39bc9a0 to 798a1a8 Compare January 12, 2023 16:53
@bmish bmish merged commit 2a998b3 into master Jan 12, 2023
@bmish bmish deleted the reportUnusedDisableDirectives-config branch January 12, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking changes for major releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant