-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dust off and update V8 to 12.2 #160
Open
bpcreech
wants to merge
110
commits into
sqreen:master
Choose a base branch
from
bpcreech:main
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BTW docs can be previewed at https://bpcreech.com/PyMiniRacer |
(Moving build yml to match what the readme has.)
This also improves errors on parse and fixes error message type to be str (not bytes).
* Make callbacks actually reusable * Add arbitrary Python callbacks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of changes here. From HISTORY.md:
present a small breaking change for advanced usage; the
EXTENSION_PATH
andEXTENSION_NAME
module variables, andMiniRacer.v8_flags
andMiniRacer.ext
class variable have all been removed.
use fast startup snapshots
A lot of these changes are just trying to update the package to "Python ecosystem 2024" (i.e., Hatch and friends).
I ended up making these updates in interleaved order in a way that's not useful for incremental review, so I just squashed to one commit. I could split this back out into logical changes if that's useful, but it will take some hours. :)
I'm not sure if this should be a PR, or if we should move the official repo, or what; depends on what the ex-Sqreen folks think!