fix(postgres): Handling of the decimal column in the build query #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toru-Takagi
changed the title
kyleconroy
approved these changes
Jan 22, 2024
|
Thanks for the fix! I'll cut a new release in a few days. |
|
Thank you for checking despite your busy schedule. |
|
I apologize for the inconvenience while you are busy with the Go and TypeScript support. Will it take much longer for the release? It's tough having to manually rewrite every time I generate. Other team members are also having trouble. I'm sorry for the inconvenience, but I appreciate your consideration. 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fiix: #18
Problem
When creating a
decimal(19, 4)column in PostgreSQL, it generates a data class with a property of typejava.math.BigDecimal?.However, when generating a query for a table with this column, the code
results.getjava.math.BigDecimal()is produced. It seems that the correct code should beresults.getBigDecimal().