Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM. Private packages #501

Merged
merged 2 commits into from
Aug 1, 2024
Merged

NPM. Private packages #501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4aa2901
NPM_TOKEN
alexanderM91 Jul 12, 2024
0601d61
A check for dev mode
alexanderM91 Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bin/sdk/assets/baked.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ function Assets::build() {
--build-arg "SPRYKER_PIPELINE=${SPRYKER_PIPELINE}" \
--build-arg "SPRYKER_BUILD_HASH=${SPRYKER_BUILD_HASH:-"current"}" \
--build-arg "SPRYKER_BUILD_STAMP=${SPRYKER_BUILD_STAMP:-""}" \
--build-arg "SPRYKER_NPM_TOKEN=${SPRYKER_NPM_TOKEN:-""}" \
. 1>&2

Console::end "[DONE]"
Expand Down
1 change: 1 addition & 0 deletions bin/sdk/images/common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ function Images::_buildApp() {
--build-arg "SPRYKER_PIPELINE=${SPRYKER_PIPELINE}" \
--build-arg "SPRYKER_BUILD_HASH=${SPRYKER_BUILD_HASH:-"current"}" \
--build-arg "SPRYKER_BUILD_STAMP=${SPRYKER_BUILD_STAMP:-""}" \
--build-arg "SPRYKER_NPM_TOKEN=${SPRYKER_NPM_TOKEN:-""}" \
. 1>&2

if [ -n "${SPRYKER_XDEBUG_MODE_ENABLE}" ]; then
Expand Down
8 changes: 8 additions & 0 deletions images/baked/assets/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,14 @@ COPY --chown=spryker:spryker package.json package-lock.json ${srcRoot}/
COPY --chown=spryker:spryker frontend* ${srcRoot}/frontend
COPY --chown=spryker:spryker tsconfig*.json ${srcRoot}/
COPY --chown=spryker:spryker config/Yves ${srcRoot}/config/Yves
COPY --chown=spryker:spryker .npmrc ${srcRoot}/

ARG SPRYKER_NPM_TOKEN
ENV SPRYKER_NPM_TOKEN=${SPRYKER_NPM_TOKEN}

RUN if [ -n "$SPRYKER_NPM_TOKEN" ]; then \
sed -i "s|\${SPRYKER_NPM_TOKEN}|${SPRYKER_NPM_TOKEN}|" .npmrc; \
fi

ARG SPRYKER_ASSETS_MODE='development'
ENV SPRYKER_ASSETS_MODE=${SPRYKER_ASSETS_MODE}
Expand Down
3 changes: 3 additions & 0 deletions images/mount/cli/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,6 @@ FROM ${SPRYKER_PARENT_IMAGE} as cli-development

ENV DEVELOPMENT_CONSOLE_COMMANDS=1

ARG SPRYKER_NPM_TOKEN
ENV SPRYKER_NPM_TOKEN=${SPRYKER_NPM_TOKEN}

Loading