Skip to content

Commit

Permalink
removed default for SPRYKER_PHP_IMAGE while building arguments
Browse files Browse the repository at this point in the history
  • Loading branch information
maritechpro committed Sep 6, 2024
1 parent 860f899 commit ff9ecd0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion bin/sdk/assets/baked.sh
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ function Assets::build() {
-f "${DEPLOYMENT_PATH}/images/baked/assets/Dockerfile" \
--progress="${PROGRESS_TYPE}" \
--build-arg "SPRYKER_PARENT_IMAGE=${cliImage}" \
--build-arg "SPRYKER_PHP_IMAGE=${SPRYKER_PHP_IMAGE:-spryker/php:8.2}" \
--build-arg "SPRYKER_PHP_IMAGE=${SPRYKER_PHP_IMAGE}" \
--build-arg "SPRYKER_ASSETS_MODE=${mode}" \
--build-arg "SPRYKER_PIPELINE=${SPRYKER_PIPELINE}" \
--build-arg "SPRYKER_BUILD_HASH=${SPRYKER_BUILD_HASH:-"current"}" \
Expand Down
4 changes: 2 additions & 2 deletions bin/sdk/images/common.sh
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ function Images::_buildApp() {
-f "${DEPLOYMENT_PATH}/images/common/application/Dockerfile" \
--progress="${PROGRESS_TYPE}" \
--build-arg "SPRYKER_PLATFORM_IMAGE=${SPRYKER_PLATFORM_IMAGE}" \
--build-arg "SPRYKER_PHP_IMAGE=${SPRYKER_PHP_IMAGE:-spryker/php:8.2}" \
--build-arg "SPRYKER_PHP_IMAGE=${SPRYKER_PHP_IMAGE}" \
--build-arg "SPRYKER_LOG_DIRECTORY=${SPRYKER_LOG_DIRECTORY}" \
--build-arg "SPRYKER_PIPELINE=${SPRYKER_PIPELINE}" \
--build-arg "APPLICATION_ENV=${APPLICATION_ENV}" \
Expand All @@ -74,7 +74,7 @@ function Images::_buildApp() {
--secret "id=secrets-env,src=$SECRETS_FILE_PATH" \
--progress="${PROGRESS_TYPE}" \
--build-arg "SPRYKER_PARENT_IMAGE=${baseAppImage}" \
--build-arg "SPRYKER_PHP_IMAGE=${SPRYKER_PHP_IMAGE:-spryker/php:8.2}" \
--build-arg "SPRYKER_PHP_IMAGE=${SPRYKER_PHP_IMAGE}" \
--build-arg "SPRYKER_DOCKER_PREFIX=${SPRYKER_DOCKER_PREFIX}" \
--build-arg "SPRYKER_DOCKER_TAG=${SPRYKER_DOCKER_TAG}" \
--build-arg "USER_UID=${USER_FULL_ID%%:*}" \
Expand Down

0 comments on commit ff9ecd0

Please sign in to comment.