Fix generator multi store store specific executor conditions (#496)

* Fix conditions where a non-existing structure is examined and therefore it's always true
spryker · May 22, 2024 · 4e9cd42 · 4e9cd42
1 parent 6f87cc2
commit 4e9cd42
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/...ct-data/src/DataBuilder/MultiStore/Executor/StoreSpecific/StoreSpecificBrokerExecutor.php b/...ct-data/src/DataBuilder/MultiStore/Executor/StoreSpecific/StoreSpecificBrokerExecutor.php
@@ -26,7 +26,7 @@ public function exec(array $projectData): array
         foreach ($projectData[ProjectDataRegionsConstants::REGIONS_KEY] as $regionName => $regionData) {
             $regionServices = $regionData[ProjectDataServicesConstants::SERVICES_KEY] ?? [];
 
-            if (!isset($services[ProjectDataServicesConstants::BROKER_KEY][ProjectDataServicesConstants::SERVICES_NAMESPACE_KEY])) {
+            if (!isset($regionServices[ProjectDataServicesConstants::BROKER_KEY][ProjectDataServicesConstants::SERVICES_NAMESPACE_KEY])) {
                 continue;
             }
 

diff --git a/.../src/DataBuilder/MultiStore/Executor/StoreSpecific/StoreSpecificKeyValueStoreExecutor.php b/.../src/DataBuilder/MultiStore/Executor/StoreSpecific/StoreSpecificKeyValueStoreExecutor.php
@@ -26,7 +26,7 @@ public function exec(array $projectData): array
         foreach ($projectData[ProjectDataRegionsConstants::REGIONS_KEY] as $regionName => $regionData) {
             $regionServices = $regionData[ProjectDataServicesConstants::SERVICES_KEY] ?? [];
 
-            if (!isset($services[ProjectDataServicesConstants::KEY_VALUE_STORE_KEY][ProjectDataServicesConstants::SERVICES_NAMESPACE_KEY])) {
+            if (!isset($regionServices[ProjectDataServicesConstants::KEY_VALUE_STORE_KEY][ProjectDataServicesConstants::SERVICES_NAMESPACE_KEY])) {
                 continue;
             }
 

diff --git a/...t-data/src/DataBuilder/MultiStore/Executor/StoreSpecific/StoreSpecificSessionExecutor.php b/...t-data/src/DataBuilder/MultiStore/Executor/StoreSpecific/StoreSpecificSessionExecutor.php
@@ -26,7 +26,7 @@ public function exec(array $projectData): array
         foreach ($projectData[ProjectDataRegionsConstants::REGIONS_KEY] as $regionName => $regionData) {
             $regionServices = $regionData[ProjectDataServicesConstants::SERVICES_KEY] ?? [];
 
-            if (!isset($services[ProjectDataServicesConstants::SESSION_KEY][ProjectDataServicesConstants::SERVICES_NAMESPACE_KEY])) {
+            if (!isset($regionServices[ProjectDataServicesConstants::SESSION_KEY][ProjectDataServicesConstants::SERVICES_NAMESPACE_KEY])) {
                 continue;
             }