Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade com.gradle.enterprise plugin to 3.16.2 #1140

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

qeeqez
Copy link
Contributor

@qeeqez qeeqez commented Feb 29, 2024

Upgrade Enterprise Gradle Plugin

Bumps

Compatibility

Based on commits in spring-framework repo, internally spring team should support latest Gradle Enterprise plugin:

@jvalkeal
Copy link
Contributor

Thx for a PR. We just went through full overhaul of a gradle build so location of these versions changed. I'll handle this myself a bit later.

@qeeqez qeeqez force-pushed the update-gradle-enterprise branch from c89d8be to eb71d7b Compare March 15, 2024 11:01
@qeeqez
Copy link
Contributor Author

qeeqez commented Mar 15, 2024

@jvalkeal Hi, I see you are trying to bump gradle to the latest one. I want to help a little 🙂

To avoid all gradle deprecation warnings you need:

Pushed to this pull request

  • new versions of gradle enterprise and ge conventions, see 6f2b5fd
  • java {} block for the sourceCompatibility line, see eb71d7b

What should be done:

  1. Replace usage of "JavaPluginConvention.class" in RootPlugin.java with this:
SourceSetContainer sourceSets = project.getExtensions().getByType(JavaPluginExtension.class).getSourceSets();
SourceSet mainSourceSet = sourceSets.getByName(SourceSet.MAIN_SOURCE_SET_NAME);

p.s. now it fails to build, as java plugin is not recognized in the buildSrc project, something wrong with dependencies

  1. Junit must be called with testRuntimeOnly according to Gradle Docs:
    testRuntimeOnly("org.junit.platform:junit-platform-launcher")

  2. If you'll use "spring java format" plugin (other spring projects have it), use latest 0.0.41

@jvalkeal jvalkeal added this to the 4.0.1 milestone Mar 19, 2024
@jvalkeal jvalkeal merged commit 400a659 into spring-projects:main Mar 21, 2024
5 checks passed
@qeeqez qeeqez deleted the update-gradle-enterprise branch March 21, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants