Allow unescaped underscores in filter expression keys #1483
+102
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at NoViableAltException is no longer thrown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for unescaped underscores in filter expresssion keys similar to how SQL allows tables and columns to have underscores.
I have submitted as 3 commits so you can see it was only a small code change in first commit, the 2nd one is autogenerated by antlr4 maven plugin and the 3rd is a new test case showing unescaped underscores are now accepted.
Feel free to re run the autogeneration to verify change
Fixes #696 - Default metadata field names in PagePdfDocumentReader are can't be parsed in a filter expression