Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Add a specific description of ServiceInstance is empty #1291

Closed
wants to merge 1 commit into from

Conversation

RealBeBetter
Copy link
Contributor

If the ServiceInstance is empty, the prompt information is too crude, which will increase the difficulty of user investigation.

@RealBeBetter
Copy link
Contributor Author

The following is the error when using:
image

Copy link
Collaborator

@OlgaMaciaszek OlgaMaciaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @RealBeBetter. This looks good, but can you please submit it against 3.1.x instead of main, like this we will include the change in all the supported versions. Also, please update the copyright entry on top of the file to say 2012-2023, since the file is being updated.

@RealBeBetter
Copy link
Contributor Author

Thanks, @RealBeBetter. This looks good, but can you please submit it against 3.1.x instead of main, like this we will include the change in all the supported versions. Also, please update the copyright entry on top of the file to say 2012-2023, since the file is being updated.

I have recreated a new Pull Request. Please check.

@OlgaMaciaszek
Copy link
Collaborator

To do that you need to make a change in your 3.1.x branch, not main. And then create the PR. from your 3.1.x to Spring Cloud 3.1.x.

@RealBeBetter
Copy link
Contributor Author

To do that you need to make a change in your 3.1.x branch, not main. And then create the PR. from your 3.1.x to Spring Cloud 3.1.x.

Sorry, I have resubmitted this time. The address is:
pull request

@OlgaMaciaszek
Copy link
Collaborator

Closing in favour of #1297.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants