Merge pull request #287 from spree-contrib/page-title-and-meta-title

Fix rendering page title and meta title

app/controllers/spree/static_content_controller.rb

@@ -15,7 +15,7 @@ def determine_layout
     end
 
     def accurate_title
-      @page ? (@page.meta_title.present? ? @page.meta_title : @page.title) : nil
+      @page&.title || @page&.meta_title
     end
   end
 end

app/views/spree/static_content/show.html.erb

@@ -3,9 +3,9 @@
 <% else %>
   <% content_for :head do -%>
     <%- if @page.meta_title.present? -%>
-      <meta name="title" content="<%= @page.title %>">
-    <%- else -%>
       <meta name="title" content="<%= @page.meta_title %>">
+    <%- else -%>
+      <meta name="title" content="<%= @page.title %>">
     <%- end -%>
     <meta name="keywords" content="<%= @page.meta_keywords %>">
     <meta name="description" content="<%= @page.meta_description %>">

spec/features/static_content_spec.rb

@@ -60,5 +60,27 @@
 
       expect(page).to have_text 'WOMEN'.upcase
     end
+
+    scenario 'has valid title' do
+      create(:page, slug: '/page', title: 'Title', meta_title: 'Meta Title', stores: [store])
+      visit '/page'
+      expect(page).to have_title('Title')
+    end
+
+    context 'when meta title is present' do
+      scenario 'has valid meta title' do
+        create(:page, slug: '/page', title: 'Title', meta_title: 'Meta Title', stores: [store])
+        visit '/page'
+        expect(page.has_css?("meta[name='title'][content='Meta Title']", visible: false)).to eq true
+      end
+    end
+
+    context 'when meta title is not present' do
+      scenario 'has meta title like title' do
+        create(:page, slug: '/page', title: 'Title', meta_title: nil, stores: [store])
+        visit '/page'
+        expect(page.has_css?("meta[name='title'][content='Title']", visible: false)).to eq true
+      end
+    end
   end
 end