Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid pluralization of Spree::RelationType #115

Open
wants to merge 1 commit into
base: 3-0-stable
Choose a base branch
from

Conversation

jumski
Copy link

@jumski jumski commented Jun 28, 2015

I believe this is same stuff as #107 (related to spree/spree#5842)

Please tell if i should base this on master.

Thanks

@futhr
Copy link
Contributor

futhr commented Jun 28, 2015

Hi @jumski, this fix works for both 3-0-stable and master.

@jumski
Copy link
Author

jumski commented Jun 29, 2015

So this should be based on master? Not sure how you propagate this to the stable branch.

@futhr
Copy link
Contributor

futhr commented Jul 2, 2015

Hi @jumski, no worries we can cherry-pick it across branches when the failing specs been resolved.

@jumski
Copy link
Author

jumski commented Jul 2, 2015

I don't know how to fix this error, seems unrelated to my changes.

I have checked out 3-0-stable branch and running tests results in same error:

/home/jumski/.rvm/gems/ruby-2.1.5/bundler/gems/spree-438dd5e58c0d/core/lib/spree/testing_support/controller_requests.rb:32:inblock in module:ControllerRequests': undefined method routes' for #<Class:0x00000007181698> (NoMethodError)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants