Fix SpreeBraintreeVzero loading issues #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damianlegawiec
approved these changes
Apr 16, 2021
vitkx
pushed a commit
to vitkx/spree_braintree_vzero
that referenced
this pull request
Sep 4, 2024
Fix SpreeBraintreeVzero loading issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is fixing the
ReferenceError: Can't find variable: SpreeBraintreeVzeroissue. Also, it fixes the issue when you can't click thePay with PayPalbutton, by waiting for the document to load first.I am not using the
turbolinks:loadevent because this event triggers multiple times in the site (because it triggers for the original document and for each cached version) and there is no easy way around it.I was worried about
addEventListenerwith theclickbecause sometimes this script runes twice, but I totally forgot that the browser will not add another event with the same function and the samecapturesetting.Closes #228