Move out OptionFormat from StandardFormats to allow mix with custom implicits modules #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix an issue with a custom implicits module due to
OptionFormatbeing an inner class ofStandardFormatsbreaking the match inProductFormats.productElement2Fieldwhen custom module implicits are used:spray-json/src/main/scala/spray/json/ProductFormats.scala
Line 46 in a2b4986
Changes include a test case that reproduces the issue.
The patch is my original work and I license the work to the spray-json project under the project’s open source license.