Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The change from #153 included not needed dependencies for .net Standard 2.x, those are only required for ns1.x. #162

Closed
MagicAndre1981 opened this issue Sep 30, 2020 · 8 comments

Comments

@MagicAndre1981
Copy link
Contributor

The change from #153 included not needed dependencies for .net Standard 2.x, those are only required for ns1.x.

image

This includes a lot of old packages which are not needed at all.

Can this be fixed?

Originally posted by @MagicAndre1981 in #152 (comment)

@nblumhardt
Copy link
Member

Thanks for the note, not sure how that one slipped past me! :-) ... A PR would be great if anyone is able to look into this 👍

@MagicAndre1981
Copy link
Contributor Author

ok, I created a PR #163 when I installed my test version in my Xamarin.Forms Android project with packages.config, I no longer get offered to install the other packages.

nblumhardt added a commit that referenced this issue Oct 7, 2020
@nblumhardt
Copy link
Member

Fixed in #163

@MagicAndre1981
Copy link
Contributor Author

Fixed in #163

when will the stable version be released?

@nblumhardt
Copy link
Member

Just created release PR #167 - thanks @MagicAndre1981 👍

@MagicAndre1981
Copy link
Contributor Author

Just created release PR #167 - thanks @MagicAndre1981

the new stable release was never published and the PR failed to build 🤔

@nblumhardt
Copy link
Member

Looks like we need to make some updates to the CSPROJ. It's surprising that sl5 is still a supported target in there! Time to modernize :-)

@MagicAndre1981
Copy link
Contributor Author

It's surprising that sl5 is still a supported target in there! Time to modernize :-)

I created a new issue for this to track.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants