Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time to modernize csproj and drop old TargetFramework entries #172

Closed
MagicAndre1981 opened this issue Jun 9, 2021 · 10 comments · Fixed by #173
Closed

Time to modernize csproj and drop old TargetFramework entries #172

MagicAndre1981 opened this issue Jun 9, 2021 · 10 comments · Fixed by #173

Comments

@MagicAndre1981
Copy link
Contributor

Looks like we need to make some updates to the CSPROJ. It's surprising that sl5 is still a supported target in there! Time to modernize :-)

Originally posted by @nblumhardt in #162 (comment)

@MagicAndre1981
Copy link
Contributor Author

Which targets should be supported? Only .net standard 2.x?

@nblumhardt
Copy link
Member

Thanks! 👍

I think netstandard2.0 and net5.0 would be my picks; it's largely a matter of opinion, though.

For netstandard2.0, null checking can be enabled with some fiddling around, and this would keep (newer) .NET Framework versions supported, while not requiring .NET Framework to be installed during development.

net5.0 has a lower deployment footprint and will be a better fit for newer apps.

@MagicAndre1981
Copy link
Contributor Author

.net core 3.1 is LTS and has netstandard2.1 support. Does this bring any benefit over netstandard2.0 when using the lib in .net core 3.1 project?

@nblumhardt
Copy link
Member

Would guess there's some modest benefit, but, also some advantages to starting fresh without additional targets to carry forwards :-)

@MagicAndre1981
Copy link
Contributor Author

I would go with netstandard2.0 (classic .net framework, Xamarin.Android with VS2017 and UWP), netstandard2.1 (Xamarin.Android with VS2019 and .net core 3.1) and net5.0 to have best compatibility.

@nblumhardt
Copy link
Member

I could live with that! :-) 👍

@MagicAndre1981
Copy link
Contributor Author

Do you already had some time?

@nblumhardt
Copy link
Member

Thanks for the nudge! Sorry, no, not looking good for the next few weeks - all help appreciated.

@MagicAndre1981
Copy link
Contributor Author

all help appreciated.

I made a quick fix in PR #173 .

You should look later in code for old hacks that can be removed.

@MagicAndre1981
Copy link
Contributor Author

what about .net 6 support and final release of version 3 of the lib? @nblumhardt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants