-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C++ improvements #63
Merged
+344
−112
Merged
C++ improvements #63
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
674e914
Refactor cpp structure
markkohdev 9a68237
Start to add tests
markkohdev 059c7bd
Try to clean up my mess a bit. Also add PR template
markkohdev 024eee0
Clean up documentation and got tests running
markkohdev 074b1bb
Uncomment the other tests but they failing right now
markkohdev 5a1e371
Fix java and python cpp src paths
markkohdev d86ebbb
Improve formatting strategy
markkohdev 314bd82
Run C++ formatter
markkohdev 9cdbc4e
Add .clang-format to root for CI
markkohdev 9888690
Update clang-format action container
markkohdev 6a873c2
Fix find command
markkohdev 98214a5
Start to replace Catch2 with doctest. Dummy test only
markkohdev befa6b2
Remove commented test code until namespacing is implemented
markkohdev 6722eb6
Add some actual doctest tests
markkohdev f2f1156
Use doctest and add combination var checks
markkohdev ec40dc9
Add c++ tests to github workflows
markkohdev 152b894
Fix rebase error
markkohdev cf09244
Update javadoc
markkohdev 3f87ed0
Undo docs changes for cleaner PR
markkohdev ba06fd2
Add EOF EOL
markkohdev 0532250
Revert cpp spacing to 80 for cleaner PR
markkohdev 598e9e6
Fix TypedIndex rebase
markkohdev 753175f
Add c++ tests to github actions
markkohdev 4f98c93
Add build dir for cmake
markkohdev 1f6c0b1
Fix windows tests
markkohdev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
cpp/.clang-format | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
## Description | ||
<!-- Describe the changes introduced by this pull request and why they are necessary. --> | ||
|
||
## Related Issues | ||
<!-- Reference any related GitHub issues that are addressed by this pull request. --> | ||
|
||
## Changes Made | ||
<!-- Provide a brief overview of the changes made in this pull request. --> | ||
|
||
### C++ | ||
<!-- Describe changes made to the C++ code, including any new features, improvements, or bug fixes. --> | ||
|
||
### Python | ||
<!-- Describe changes made to the Python code, including any new features, improvements, or bug fixes. --> | ||
|
||
### Java | ||
<!-- Describe changes made to the Java code, including any new features, improvements, or bug fixes. --> | ||
|
||
## Testing | ||
<!-- Outline the testing strategy employed to validate these changes. Include any relevant test cases or scenarios. --> | ||
|
||
## Checklist | ||
<!-- | ||
Replace [ ] with [x] to check off items. | ||
For items that are not applicable, simply remove the checkbox. | ||
--> | ||
|
||
- [ ] My code follows the code style of this project. | ||
- [ ] I have added and/or updated appropriate documentation (if applicable). | ||
- [ ] All new and existing tests pass locally with these changes. | ||
- [ ] I have run static code analysis (if available) and resolved any issues. | ||
- [ ] I have considered backward compatibility (if applicable). | ||
- [ ] I have confirmed that this PR does not introduce any security vulnerabilities. | ||
|
||
## Additional Comments | ||
<!-- Add any additional comments or notes that might be helpful for reviewers or contributors. --> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
[submodule "cpp/include/doctest"] | ||
path = cpp/include/doctest | ||
url = git@github.com:doctest/doctest.git |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
--- | ||
BasedOnStyle: LLVM | ||
IndentWidth: 2 | ||
InsertNewlineAtEOF: true | ||
--- | ||
Language: Cpp | ||
# Use 120 columns since we have big screens now | ||
ColumnLimit: 80 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
softlink to allow the clang-format github action to work correctly