Fix windows tests

.github/workflows/all.yml

@@ -52,9 +52,6 @@ jobs:
         # TODO: Switch back to macos-latest once https://github.com/actions/python-versions/pull/114 is fixed
         os:
           - 'ubuntu-latest'
-          # TODO: Fix failing CMake build on windows:
-          #   Error: `cl : command line  error D8016: '/O2' and '/RTC1' command-line options are incompatible [D:\a\voyager\voyager\cpp\test\test.vcxproj]`
-          #   I've tried passing CXX flags, but windows doesn't seem to respect disabling runtime checks with /RTC1 or disabling optimizations with /O2
           - windows-latest
           - macos-12
     name: Test C++ on ${{ matrix.os }}
@@ -66,7 +63,6 @@ jobs:
         if: matrix.os == 'windows-latest'
         run: |
           choco install cmake --installargs 'ADD_CMAKE_TO_PATH=System'
-          choco install ninja
       - name: Install CMake (MacOS)
         if: matrix.os == 'macos-12'
         run: brew install cmake

cpp/CMakeLists.txt

@@ -5,17 +5,6 @@ set(CMAKE_CXX_STANDARD 17)
 set(LLVM_CXX_STD 17)
 set(CMAKE_CXX_STANDARD_REQUIRED ON)
 
-if (MSVC)
-    # Set /RTC1 only for Debug builds
-    set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} /RTC1")
-
-    # Ensure /RTC1 is not used in Release builds
-    set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} /O2")
-
-    # Optionally, remove /RTC1 from the global CXX flags to avoid conflicts
-    string(REGEX REPLACE "/RTC1" "" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
-endif()
-
 enable_testing()
 
 add_subdirectory(include)
@@ -38,4 +27,3 @@ add_custom_target(format
     COMMAND ${FORMAT_COMMAND} `${FIND_COMMAND}`
     COMMENT "Running C++ formatter"
 )
-

cpp/Makefile

@@ -9,7 +9,7 @@ build: cmake
 	cmake --build ${BUILD_DIR}
 
 test: build
-	cmake --build ${BUILD_DIR} --target test
+	ctest --test-dir ${BUILD_DIR}
 
 clean:
 	rm -rf ${BUILD_DIR}/*

cpp/src/E4M3.h

@@ -21,6 +21,7 @@
 #pragma once
 
 #include <cmath>
+#include <string>
 
 static constexpr float ALL_E4M3_VALUES[256] = {
     0,

cpp/src/Enums.h

@@ -1,5 +1,7 @@
 #pragma once
 
+#include <string>
+
 /**
  * The space (i.e. distance metric) to use for searching.
  */

cpp/test/CMakeLists.txt

@@ -13,9 +13,6 @@ target_link_libraries(VoyagerTests
         doctest
 )
 
-# Add the tests
-add_test(NAME VoyagerTests COMMAND VoyagerTests)
-
 # Discover tests using Doctest
 include(${CMAKE_SOURCE_DIR}/include/doctest/scripts/cmake/doctest.cmake)
 doctest_discover_tests(VoyagerTests)