Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional example using Nextjs and Vanillajs #2

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Additional example using Nextjs and Vanillajs #2

wants to merge 11 commits into from

Conversation

parrott-kevin
Copy link

Nextjs

  • User now has the option to try both implicit and auth code flows for login
  • Switch from imported css to styled components
  • Typescript

Vanillajs

  • Implicit flow
  • npm / node is only used to serve the project otherwise this is free of dependencies

@parrott-kevin parrott-kevin marked this pull request as ready for review May 6, 2022 16:53
anth-volk
anth-volk reviewed May 18, 2023
View reviewed changes
vanillajs/public/js/musicBox.js Outdated
setInfo(info) {
const cover = document.getElementById('np-cover');
cover.setAttribute('src', info.album.images[0].url);
cover.setAttribute('alt', `cover art for ${info.album.name}`);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tag @Act0fKindness

anth-volk
anth-volk reviewed May 18, 2023
View reviewed changes
Copy link

@anth-volk anth-volk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really appreciate being roped in on this project. I have no experience with NextJS, so I didn't review anything there, but from what I saw with the vanilla JS version, the codebase looks clean and functional. I'd love to contribute testing, where necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anth-volk anth-volk anth-volk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parrott-kevin @anth-volk