-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support verification of download and install size #168
Conversation
ruler-common/src/main/java/com/spotify/ruler/common/veritication/VerificationException.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
6fd2859
to
56b0454
Compare
Thanks for the review, @ViktorPetrovski. Unfortunately, CI seems to fail with a reason unrelated to this changeset. I made an attempt to fix that through #169. |
Accidentally deleted this branch on my fork, my bad. Reopening the PR. |
@MrHadiSatrio Lets rebase and get this thing merged |
56b0454
to
271dd3c
Compare
271dd3c
to
1ae38c7
Compare
1ae38c7
to
97d2853
Compare
Done @ViktorPetrovski. Have also updated the README. Please have a look. |
What has changed
Ruler now supports verification of AAB download and install sizes against user-defined thresholds. This new feature allows developers to ensure their app bundles meet size requirements before deployment.
Example configuration:
If the AAB exceeds either threshold during the
analyze<Variant>Bundle
task, Ruler will throw aVerificationException
:Why was it changed
If an end user requires such functionality, they would currently have to either implement a processor for Ruler's output files or depend on other tools (e.g.,
apkanalyzer
). Having this built into Ruler would help centralize that logic, thus reducing potential duplication.