Extract APK Creator in common module #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorPetrovski
force-pushed
the
extract-apk-creator
branch
from
b4f2e42 to
9275d49
Compare
nathan3d
approved these changes
Dec 14, 2023
The old code worked for Gradle modules, but with the RulerCli and the possibility to pass componenets that are build with other build systems this is no longer correct
ViktorPetrovski
force-pushed
the
extract-apk-creator
branch
from
9275d49 to
26716c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has changed
Extract the ApkCreator in the common module and create split apks from aabs.
Why was it changed
Making it possible to pass an aab bundle in Ruler CLI and ruler to create the split apks.