Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Beam schemas #1027

Merged
merged 32 commits into from
Sep 17, 2024
Merged

Add support for Beam schemas #1027

merged 32 commits into from
Sep 17, 2024

Conversation

kellen
Copy link
Contributor

@kellen kellen commented Aug 22, 2024

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 98.22222% with 4 lines in your changes missing coverage. Please review.

Project coverage is 95.50%. Comparing base (c373085) to head (50f67ec).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
shared/src/main/scala/magnolify/shared/Time.scala 95.31% 3 Missing ⚠️
beam/src/main/scala/magnolify/beam/RowType.scala 98.83% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1027      +/-   ##
==========================================
+ Coverage   95.23%   95.50%   +0.27%     
==========================================
  Files          51       56       +5     
  Lines        1845     1980     +135     
  Branches      160      186      +26     
==========================================
+ Hits         1757     1891     +134     
- Misses         88       89       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

beam/src/main/scala/magnolify/beam/BeamSchemaType.scala Outdated Show resolved Hide resolved
beam/src/main/scala/magnolify/beam/BeamSchemaType.scala Outdated Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
docs/mapping.md Outdated Show resolved Hide resolved
Copy link
Contributor

@clairemcginty clairemcginty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! only a few minor comments

beam/src/main/scala/magnolify/beam/BeamSchemaType.scala Outdated Show resolved Hide resolved
beam/src/main/scala/magnolify/beam/BeamSchemaType.scala Outdated Show resolved Hide resolved
Copy link
Contributor

@RustedBones RustedBones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we've used TableRow type for BQ, we should use RowType here

@kellen kellen merged commit a3708ba into main Sep 17, 2024
13 checks passed
@kellen kellen deleted the kellen/beam branch September 17, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants